Skip to content

Add key validation for FileStore #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Mar 20, 2025

The following adds key validation for the FileStore. This just ensures that the key passed in follows the format that is expected.

  1. Ensure the key passed in leads to a JSON file.

  2. Only allow alphanumeric characters, hyphens, and underscores in the base filename

This ensures _getPath will enforce the following rules.

@TarikGul TarikGul added the -auto label Apr 2, 2025
@polkadot-js-bot polkadot-js-bot merged commit 1a6fde7 into master Apr 2, 2025
5 checks passed
@polkadot-js-bot polkadot-js-bot deleted the tg-add-key-validation branch April 2, 2025 14:01
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants